[U-Boot] [PATCH 2/2] da850evm: read mac address from I2C EEPROM on AM18x EVM

[Wolfgang Denk]

Dear Manjunath Hadli,

In message <1328190138-5276-3-git-send-email-manjunath.hadli at ti.com> you wrote:
> add support to read mac address for AM18x EVM manufactured from
> Spectrum digital which have mac address stored in I2C EEPROM manfactured
> by WINBOND. This patch reads mac address from I2C EEPROM and updates
> environment variable if not set. Introduced a config option
> CONFIG_MAC_ADDR_IN_EEPROM to where to look for the mac address.
> 
> Signed-off-by: Manjunath Hadli <manjunath.hadli at ti.com>
> Cc: Tom Rini <trini at ti.com>

NAK.  This has been discussed a thousand times before, so please look
it up in the archives.

The environment always has precedence. If there are several places to
store tha MAC address, and the values don;t match, a warning must be
issued. etc.


While you are at it, the implementation of davinci_sync_env_enetaddr()
should be cleaned up as well.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Fascinating, a totally parochial attitude.
	-- Spock, "Metamorphosis", stardate 3219.8