[U-Boot] [PATCH 2/2] da850evm: read mac address from I2C EEPROM on AM18x EVM

[Hadli, Manjunath]

Wolfgang,

On Fri, Feb 03, 2012 at 03:47:47, Wolfgang Denk wrote:
> Dear Manjunath Hadli,
> 
> In message <1328190138-5276-3-git-send-email-manjunath.hadli at ti.com> you wrote:
> > add support to read mac address for AM18x EVM manufactured from 
> > Spectrum digital which have mac address stored in I2C EEPROM 
> > manfactured by WINBOND. This patch reads mac address from I2C EEPROM 
> > and updates environment variable if not set. Introduced a config 
> > option CONFIG_MAC_ADDR_IN_EEPROM to where to look for the mac address.
> > 
> > Signed-off-by: Manjunath Hadli <manjunath.hadli at ti.com>
> > Cc: Tom Rini <trini at ti.com>
> 
> NAK.  This has been discussed a thousand times before, so please look it up in the archives.
> 
> The environment always has precedence. If there are several places to store tha MAC address, and the values don;t match, a warning must be issued. etc.
> 
This is not a case where we are matching the mac address
with the environment variable. If the environment variable
is not set we try to get it from either spi or i2c eeprom.
Since da850evm/L138 have mac address stored in spi flash
and am18x in i2c eeprom, picks appropriately from the source
based on the configuration file setting.

Let me know if you still don't agree. If not can suggest if
the environment variable is not set. 
> 
> While you are at it, the implementation of davinci_sync_env_enetaddr() should be cleaned up as well.
Well can you put some more light on it as what cleanup is to be done ?

Regards,
--Manju
> 
> Best regards,
> 
> Wolfgang Denk
> 
> -- 
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Fascinating, a totally parochial attitude.
> 	-- Spock, "Metamorphosis", stardate 3219.8
>