[U-Boot] [PATCH 1/7] net/designware: Fix to restore hw mac address

Mike Frysinger vapier at gentoo.org
Wed Feb 29 20:09:30 CET 2012


On Wednesday 29 February 2012 05:37:20 Amit Virdi wrote:
> The network controller mac resets hardware address stored in MAC_HI and
> MAC_LO registers if mac is resetted. So, hw mac address needs to be
> restored in case mac is explicitly resetted from driver.

OK, but ...

> --- a/drivers/net/designware.c
> +++ b/drivers/net/designware.c
> 
> +	dw_write_hwaddr(dev);

... please add a comment above this line explaining why you must explicitly 
make this call
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120229/b7f182e9/attachment.pgp>


More information about the U-Boot mailing list