[U-Boot] [PATCH 5/7] usb: hub: Increase device enumeration timeout for broken drives

Vivek Gautam gautamvivek1987 at gmail.com
Tue Apr 2 15:53:59 CEST 2013


Hi Marek,


On Thu, Mar 28, 2013 at 8:02 PM, Marek Vasut <marex at denx.de> wrote:
> Dear Vivek Gautam,
>
>> Few broken usb mass storage devices can take some time to set
>> Current Connect Status (CCS) and Connect Status Change (CSC) in
>> Port status register after an attach.
>> So increasing some timeout when both CCS and CSC bits are not set.
>>
>> Signed-off-by: Amar <amarendra.xt at samsung.com>
>> Signed-off-by: Vivek Gautam <gautam.vivek at samsung.com>
>
> Can we not postpone checking of these CCS and CSC bits for such broken devices?
> This'd at least allow the "good" devices to be detected quickly and while these
> are handled, this would give some time for the "bad" ones to do their job too.

We are thinking of one approach here.
Iterating over all the ports once, so that we find 'good' ports and 'bad' ports
By 'bad' port we mean that either the device connected to it is bad or
nothing is connected
to this port.
Once we are done with "usb_hub_port_connect_change()" and other jobs
for 'good' ports,
we iterate once again on bad ports.
Not sure how good this approach :-(.  Any suggestions ?



-- 
Thanks & Regards
Vivek


More information about the U-Boot mailing list