[U-Boot] [PATCH] biosemu: include <asm/io.h> header

[Tom Rini]

On Tue, Apr 02, 2013 at 12:32:40PM +0200, Albert ARIBAUD wrote:

> Hi Linus,
> 
> On Tue, 2 Apr 2013 12:09:21 +0200, Linus Walleij
> <linus.walleij at linaro.org> wrote:
> 
> > On Tue, Apr 2, 2013 at 10:56 AM, Albert ARIBAUD
> > <albert.u.boot at aribaud.net> wrote:
> > 
> > > NAK -- no ARM target needs bios emulation, so basing the #define on ARM
> > > requirements is incorrect.
> > >
> > > Actually, ARM targets build drivers/bios_emulator/libatibiosemu.o as
> > > the result of an overlook in ./Makefile where this object is compiled
> > > unconditionally.
> > >
> > > A git grep CONFIG_BIOSEMU seems to indicate only a handful of PowerPC
> > > targets need bios emulation; I suggest doing a V2 of this patch
> > > where the object is built only for PowerPC, and the #define is removed.
> > 
> > So the patch was initiated by the discussion here:
> > http://marc.info/?l=linux-arm-kernel&m=136399798826572&w=2
> > 
> > I am looking into getting biosemu up on ARM for the PCI-equipped
> > ARM boards, but admittedly I have no idea where it'll go.
> > 
> > But this can surely wait until I have a series that can be run as well.
> 
> Indeed: when some real ARM target needs biosemu, then yes, this patch
> will make sense as part of the series that introduces this target.

Grr, I missed this discussion, sorry.  But I don't feel this falls into
the "no dead code" rule, but does fall into the "lets not make life too
hard for others" rule I have at least.  There's at least one board in
u-boot-arm now (ti814x) which can get PCI turned on, with further work,
and another that was posted recently (ti816x), and more coming down the
pipe.  And also what Linus has access to.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130403/b68e26da/attachment.pgp>