[U-Boot] [PATCH v2 8/9] samsung: trats2: add support for new board Trats2

[Piotr Wilczek]

Dear Jaehoon Chung,

> > +
> > +	/*
> > +	 * MMC device init
> > +	 * mmc0  : eMMC (8-bit buswidth)
> > +	 * mmc2  : SD card (4-bit buswidth)
> > +	 */
> > +	if (err)
> > +		debug("SDMMC0 not configured\n");
> > +	else
> > +		err = s5p_mmc_init(0, 8);
> > +
> > +	/* T-flash detect */
> > +	s5p_gpio_cfg_pin(&gpio2->x3, 4, 0xf);
> > +	s5p_gpio_set_pull(&gpio2->x3, 4, GPIO_PULL_UP);
> > +
> > +	/*
> > +	 * Check the T-flash  detect pin
> > +	 * GPX3[3] T-flash detect pin
> > +	 */
> GPX3[3]? (gpio2->x3, 4)? what's correct?
> I think GPX3[4] is right.
Yes, GPX3[4] is correct.

> > +	if (!s5p_gpio_get_value(&gpio2->x3, 4)) {
> > +		err = exynos_pinmux_config(PERIPH_ID_SDMMC2,
> PINMUX_FLAG_NONE);
> > +		if (err)
> > +			debug("SDMMC2 not configured\n");
> > +		else
> > +			err = s5p_mmc_init(2, 4);
> > +	}
> > +
> > +	return err;
> > +}
> > +

> > +
> > +/* MMC */
> > +#define CONFIG_GENERIC_MMC
> > +#define CONFIG_MMC
> > +#define CONFIG_S5P_SDHCI
> > +#define CONFIG_SDHCI
> > +#define CONFIG_MMC_SDMA
> > +#define CONFIG_MMC_ASYNC
> MMC_ASYNC is used?
No, it is not. I should remove it.

> > +#define CONFIG_MMC_DEFAULT_DEV	0
> > +
> > +#define FSTYPE_DEFAULT		"ext4"
> > +
> > +#define CONFIG_BOOTARGS		"Please use defined boot"
> > +#define CONFIG_BOOTCOMMAND	"run mmcboot"
> > +#define CONFIG_DEFAULT_CONSOLE	"console=ttySAC2,115200n8\0"
> > +

Thanks,
Piotr Wilczek