[U-Boot] [PATCH] CRITICAL error in v2013.04-rc2 (true and false not working)

Wolfgang Denk wd at denx.de
Thu Apr 4 23:47:36 CEST 2013


Dear York Sun,

In message <515DEED2.90908 at freescale.com> you wrote:
>
> Would this fix be acceptable?

No...

> +#ifdef true
> +#undef true
> +#undef false
> +
>  U_BOOT_CMD(
>         false,  CONFIG_SYS_MAXARGS,     1,      do_false,
>         "do nothing, unsuccessfully",
> @@ -171,3 +175,5 @@ U_BOOT_CMD(
>         "do nothing, successfully",
>         NULL
>  );
> +
> +#endif

... as it would completely remove the command entries if "true" was
not defined.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A right is not what someone gives you; it's what no one can take from
you.                                                   - Ramsey Clark


More information about the U-Boot mailing list