[U-Boot] [PATCH] VGA text console support

[Wolfgang Denk]

Dear Vladimir 'φ-coder/phcoder' Serbinenko,

I cannot comment on the actual technical content of your patches, but
here are a few formal comments; I highly recommend to study
http://www.denx.de/wiki/U-Boot/Patches

> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: quoted-printable

Please send plain text messages.  Do not send multipart/mixed
messages.

> Most coreboot users use just VGA text console, not graphics. Support it.
> Remaining problem is that software and hardware cursor blinking superimpose.
> I disabled software blinking locally but it's not part of this patch since
> it's not done properly.
>
> diff --git a/drivers/video/cfb_console.c b/drivers/video/cfb_console.c
> index 61e1058..0c3c26d 100644

Signed-off-by: line missing.

> +static int VIDEO_VISIBLE_COLS;
> +static int VIDEO_VISIBLE_ROWS;
> +static int VIDEO_PIXEL_SIZE;

Illegal variable names - these must always be lower case.

Also, you are meddling here with a global file.  Are you sure your
changes will have no bad effects to other use cases?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Don't tell me how hard you work.  Tell me how much you get done.
                                                     -- James J. Ling