[U-Boot] [v3] command/cache: Add flush command
Wolfgang Denk
wd at denx.de
Mon Apr 8 20:35:13 CEST 2013
Dear sun york-R58495,
In message <C707E9F4D8007146BF8DC1424B113AC70B3A6A83 at 039-SN2MPN1-012.039d.mgd.msft.net> you wrote:
>
> I think it is best to keep this patch as it and stick with the
> original flush_cache name. It uses the existing function
> flush_cache() which is available for most (if not all) architectures.
> Splitting the dcache and icache not only adds more code, but
> architecture-dependent code.
As mentioned before: reusing existing code is fine, but we already
have commands for cache handling, and adding arbitrary new ones to
implement combinations of functions makes does not scale. Assume
tomorrow someone needs to add more ganular handling for example
regarding L2 caches, etc. Would you suggest to add another set of new
commands, then? This makes no sense.
Please implement IC related operations as subcommands to the "icache"
command, and DC releated ones as subcommands to "dcache".
[In the example of L2 cache above, it would be for example sufficient
to add a "-L2" option to the "icache" / "dcache" commands.]
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A man either lives life as it happens to him, meets it head-on and
licks it, or he turns his back on it and starts to wither away.
-- Dr. Boyce, "The Menagerie" ("The Cage"), stardate unknown
More information about the U-Boot
mailing list