[U-Boot] [PATCH 2/5][v2] powerpc/mpc85xx: new SPL support for IFC NAND

[Prabhakar Kushwaha]

On 04/09/2013 06:25 AM, Scott Wood wrote:
> On 04/05/2013 09:38:32 PM, Prabhakar Kushwaha wrote:
>> On 04/06/2013 02:10 AM, Scott Wood wrote:
>>> On 03/22/2013 02:08:05 AM, Prabhakar Kushwaha wrote:
>>>> diff --git a/board/freescale/common/Makefile 
>>>> b/board/freescale/common/Makefile
>>>> index 75725b4..a4d521c 100644
>>>> --- a/board/freescale/common/Makefile
>>>> +++ b/board/freescale/common/Makefile
>>>> @@ -29,6 +29,15 @@ endif
>>>>
>>>>  LIB    = $(obj)libfreescale.o
>>>>
>>>> +MINIMAL=
>>>> +
>>>> +ifdef CONFIG_SPL_BUILD
>>>> +ifdef CONFIG_SPL_INIT_MINIMAL
>>>> +MINIMAL=y
>>>> +endif
>>>> +endif
>>>> +
>>>> +ifndef MINIMAL
>>>>  COBJS-$(CONFIG_FSL_CADMUS)    += cadmus.o
>>>>  COBJS-$(CONFIG_FSL_VIA)        += cds_via.o
>>>>  COBJS-$(CONFIG_FMAN_ENET)    += fman.o
>>>> @@ -62,6 +71,7 @@ SUBLIB-$(CONFIG_P3041DS)    += 
>>>> p_corenet/libp_corenet.o
>>>>  SUBLIB-$(CONFIG_P4080DS)    += p_corenet/libp_corenet.o
>>>>  SUBLIB-$(CONFIG_P5020DS)    += p_corenet/libp_corenet.o
>>>>  SUBLIB-$(CONFIG_P5040DS)    += p_corenet/libp_corenet.o
>>>> +endif
>>>>
>>>>  SRCS    := $(SOBJS:.o=.S) $(COBJS-y:.o=.c)
>>>>  OBJS    := $(addprefix $(obj),$(COBJS-y))
>>>
>>> If this is needed to avoid pulling in any files from this directory, 
>>> why did p1_p2_rdb_pc not need this?  Is there a particular file that 
>>> is failing to build or failing to get optimized away
>>
>> I cannot avoid this directory :(.
>> because new SPL compile this directory even after undef QIXIS defines
>>
>> #ifndef CONFIG_SPL_BUILD
>> #define CONFIG_FSL_QIXIS
>> #endif
>
> Yeah, the makefiles never see CONFIG_SPL_BUILD -- it only works for C 
> code.
>
> The P1022 SPL patch just does this in the makefile:
>
> +ifndef CONFIG_SPL_BUILD
>  COBJS-$(CONFIG_FSL_NGPIXIS)    += ngpixis.o
> +endif
>
> ...which is less intrusive.  We can revisit it if we end up actually 
> needing pixis/qixis inside an SPL.
>
>

I need to add config_mpc85xx.h here.

   #define CONFIG_MPC85xx
   #define CONFIG_FSL_IFC                 /* Enable IFC Support */
   #define CONFIG_SYS_HAS_SERDES          /* common SERDES init code */
+#include "../../arch/powerpc/include/asm/config_mpc85xx.h"

I tried just after CONFIG_P1010 but it is giving compilation error.

Just to mention, I need to provide relative path in order to compile.
I will still suggest to keep original patch, As header file location may 
change over period of time then config file needs to be updated again.

Regards,
Prabhakar