[U-Boot] [PATCH v2 3/7] pxa27x_udc: remove call to unimplemented set_GPIO_mode()

Marek Vasut marex at denx.de
Thu Apr 11 21:16:53 CEST 2013


Dear Mike Dunn,

> If CONFIG_USB_DEV_PULLUP_GPIO is defined, a link error occurs because the
> set_GPIO_mode() helper function is not implemented.  This function doesn't
> do much except make the code a little more readable, so I just manually
> coded its equivalent and removed the prototype from the header file.  It
> is invoked no where else in the code.
> 
> While I was at it, I noticed that two other function prototypes in the same
> header file are also neither implemented nor invoked anywhere, so I removed
> them as well.
> 
> Signed-off-by: Mike Dunn <mikedunn at newsguy.com>

Reviewed-by: Marek Vasut <marex at denx.de>

Best regards,
Marek Vasut


More information about the U-Boot mailing list