[U-Boot] [PATCH 3/5][v3] board/p1010rdb:Add NAND boot support using new SPL format

[Scott Wood]

On 04/11/2013 11:12:24 PM, Prabhakar Kushwaha wrote:
> On 04/12/2013 01:13 AM, Scott Wood wrote:
>> On 04/11/2013 02:25:22 AM, Prabhakar Kushwaha wrote:
>>> diff --git a/include/configs/P1010RDB.h b/include/configs/P1010RDB.h
>>> index 437ee6e..a6ef276 100644
>>> --- a/include/configs/P1010RDB.h
>>> +++ b/include/configs/P1010RDB.h
>>> @@ -33,6 +33,8 @@
>>> 
>>>  #ifdef CONFIG_P1010RDB
>>>  #define CONFIG_P1010
>>> +#define CONFIG_E500            /* BOOKE e500 family */
>>> +#include <asm/config_mpc85xx.h>
>>>  #define CONFIG_NAND_FSL_IFC
>>>  #endif
>> 
>> Why is this inside the P1010RDB ifdef?  Why do we even have a  
>> CONFIG_P1010RDB?  What other boards use this file
> 
> I am supposed to put config_mpc85xx.h after  CONFIG_P1010 define.

That doesn't have to mean *immediately* after. :-)

> That's why put under CONFIG_P1010RDB.
> CONFIG_P1010RDB is not being used for P1010 as no other board using  
> this file. It can be removed.
> 
> Just to guess may be there were plan to add make target for  
> P1014(Personality of P1010). but it never happened as it is taken  
> care by reading svr.
> I will update it.

OK.

-Scott