[U-Boot] [PATCH 3/5] ARM: OMAP: Correct save_boot_params and replace with 'C' function
Michael Cashwell
mboards at prograde.net
Mon Apr 15 18:22:17 CEST 2013
Hi Sricharan,
I very much like how you've structured this. A vast improvement!
I haven't yet tried to apply the whole series but have one quick comment. In the new function:
static void save_omap_boot_params(void)
{
...
if (!(omap_hw_init_context() ==
OMAP_INIT_CONTEXT_UBOOT_AFTER_SPL)) {
...
} else {
...
}
wouldn't it be clearer to drop the boolean negation "!" and exchange the if/else bodies?
Best regards,
-Michael Cashwell
More information about the U-Boot
mailing list