[U-Boot] [PATCH v3 7/8] add support for palm treo 680 board

[Marek Vasut]

Dear Mike Dunn,

[...]

> >> +#ifdef CONFIG_SPL_BUILD
> >> +void *memcpy(void *dest, const void *src, size_t count)
> >> +{
> > 
> > CONFIG_SPL_LIBCOMMON_SUPPORT shall give you memcpy.
> 
> This does not appear to be the case.  Unless I'm mistaken, memcpy() will be
> in either lib/libgeneric.o (lib/string.c) or arch/arm/lib/libarm.o
> (arch/arm/lib/memcpy.S) - depending on CONFIG_USE_ARCH_MEMCPY - but in
> neither case will it be in common/libcommon.o.

CONFIG_SPL_LIBGENERIC_SUPPORT then ;-)

> > [...]
> > 
> >> +void nand_boot(void)
> >> +{
> > 
> > [...]
> > 
> > Will the common/spl/ NAND loading code not cut it here? I guess it won't
> > since PXA is FUBAR when it comes to any kind of SPL loading. Do you not
> > want to fix that? I'd be really grateful if you did ;-)
> 
> Well, palmtreo680 is a special case because its nand_boot() resumes loading
> u-boot where the IPL left off.  IOW, the IPL has already loaded a portion
> of u-boot, whereas a generic nand_boot() will want to load the entire
> image.
> 
> I'd be willing to help with pxa spl code, but that might be difficult
> without hardware to test on, no?

Yes, indeed.
[...]