[U-Boot] [PATCH 3/3] x86: config: Init PCI before SPI

[Simon Glass]

Hi Graeme,

On Mon, Apr 15, 2013 at 4:43 PM, Graeme Russ <graeme.russ at gmail.com> wrote:
> Hi Simon,
>
> On Tue, Apr 16, 2013 at 7:25 AM, Simon Glass <sjg at chromium.org> wrote:
>>
>> Since the ICH SPI controller uses PCI, we must ensure that PCI is
>> available
>> before it is inited.
>>
>> This fixes the current "ICH SPI: Cannot find device" message on boot.
>
>
> Hmm, if only my new init sequence code had gained wider acceptance ;)
>
> It would have been a simple case of specifying PCI as a pre-req and the init
> sequence would have been re-ordered to suit (or thrown a compile error to
> say the sequence was impossible to build)

Yes indeed. Generic board is in now - are you going to have another
crack at it? Personally I feel that it might be better to do it after
we get driver model in.

Regards,
Simon

>
> Regards,
>
> Graeme
>
>>
>> Signed-off-by: Simon Glass <sjg at chromium.org>
>> ---
>>  include/configs/coreboot.h | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/include/configs/coreboot.h b/include/configs/coreboot.h
>> index a4aa8f7..5bacc77 100644
>> --- a/include/configs/coreboot.h
>> +++ b/include/configs/coreboot.h
>> @@ -41,6 +41,7 @@
>>  #define CONFIG_INTEL_CORE_ARCH /* Sandy bridge and ivy bridge chipsets.
>> */
>>  #define CONFIG_ZBOOT_32
>>  #define CONFIG_PHYSMEM
>> +#define CONFIG_SYS_EARLY_PCI_INIT
>>
>>  #define CONFIG_LMB
>>  #define CONFIG_OF_LIBFDT
>> --
>> 1.8.1.3
>>
>