[U-Boot] [PATCH 2/3] wandboard: Add support for carrier board MicroSD card

Wolfgang Denk wd at denx.de
Tue Apr 16 07:34:32 CEST 2013


Dear Otavio Salvador,

In message <CAP9ODKqFSMHot7tCTuxV+c14385GGd4v0onsocd4wDGcghDzKw at mail.gmail.com> you wrote:
>
> > This should be an error. What about return -EINVAL ?
> 
> Agreed, fixed locally.

To make it more clear: this should be a compile-time error, not
detected at runtime.

> > With this change, you never return an error.
> 
> Should we fail if *any* fail?

Yes, this is the good old rule of defensive programming: as soon as
you detect any kind of (critical) error, you print an error message
and bail out.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"How to make a million dollars:  First, get a million dollars."
- Steve Martin


More information about the U-Boot mailing list