[U-Boot] [PATCH 1/5][v4] powerpc/mpc85xx:No NOR boot, do not compile IFC errata A003399

[Scott Wood]

On 04/15/2013 11:19:55 PM, Prabhakar Kushwaha wrote:
> On 04/16/2013 03:11 AM, Scott Wood wrote:
>> On 04/15/2013 05:12:48 AM, Prabhakar Kushwaha wrote:
>>> diff --git a/arch/powerpc/cpu/mpc85xx/cpu_init_early.c  
>>> b/arch/powerpc/cpu/mpc85xx/cpu_init_early.c
>>> index dacfdd1..439a873 100644
>>> --- a/arch/powerpc/cpu/mpc85xx/cpu_init_early.c
>>> +++ b/arch/powerpc/cpu/mpc85xx/cpu_init_early.c
>>> @@ -25,7 +25,7 @@
>>> 
>>>  DECLARE_GLOBAL_DATA_PTR;
>>> 
>>> -#if defined(CONFIG_SYS_FSL_ERRATUM_IFC_A003399) &&  
>>> !defined(CONFIG_SYS_RAMBOOT)
>>> +#ifdef CONFIG_A003399_NOR_WORKAROUND
>> 
>> Won't this break bisectability since you don't define  
>> CONFIG_A003399_NOR_WORKAROUND until a later patch?
>> 
> 
> This workaround is only required for P1010. so for other SoC it  
> should not be defined.  For P1010 it is defined in P10101RDB.h
> also all patches of a patch set should be applied at once.
> 
> may be I am unable to understand the question.

My point is you should have P1010 define this symbol before you change  
the code here to expect it.  Otherwise, P1010 will be broken for two  
commits and break bisectability.

-Scott