[U-Boot] [PATCH v2 0/5] consolidate hang()

Andreas Bießmann andreas.devel at googlemail.com
Wed Apr 17 13:02:43 CEST 2013


This series started with intention to make a hung board visualize the
(end-)user that it does hang(). The first approach was to make all the
different hang() functions weak and provide board specific versions to
implement the 'visualization' there.
After some discussion it turned out, that there is still an interface to
visualize such states to the user: the 'bootstage' stuff.

BTW:
This is my first try sending a series with patman. All I can say is:
patman is really cool ;)

The 'microblaze: fix style in board.c' is an leftover from the first approach.

The 'nios2: fix style in board.c' is an leftover from the first approach.

The 'lib: consolidate hang()' is build tested on arm and avr32. It may
produces errors on other arches like ppc cause the previous SPL inlined hang()
function was also removed.  We need to discuss if we always pull in the
libgeneric unconditional into SPL or provide a second hang() for those boards
which do not link against libgeneric in SPL.

Changes in v2:
 * delete all hang() and provide generic lib/hang.c

Andreas Bießmann (5):
  microblaze: fix style in board.c
  nios2: fix style in board.c.
  mx31pdk: add CONFIG_SPL_LIBGENERIC_SUPPORT
  tx25: add CONFIG_SPL_LIBGENERIC_SUPPORT
  lib: consolidate hang()

 arch/arm/cpu/arm926ejs/mxs/spl_boot.c |    8 +----
 arch/arm/cpu/arm926ejs/spear/spl.c    |    7 ----
 arch/arm/lib/board.c                  |    7 +---
 arch/avr32/lib/board.c                |    6 +---
 arch/blackfin/lib/board.c             |   15 +-------
 arch/m68k/lib/board.c                 |    7 ----
 arch/microblaze/lib/board.c           |   63 +++++++++++++++------------------
 arch/mips/lib/board.c                 |    8 +----
 arch/nds32/lib/board.c                |    8 +----
 arch/nios2/lib/board.c                |   47 ++++++++++--------------
 arch/openrisc/lib/board.c             |   13 +------
 arch/powerpc/lib/board.c              |   10 +-----
 arch/sandbox/lib/board.c              |    8 +----
 arch/sh/lib/board.c                   |   10 +-----
 arch/sparc/lib/board.c                |   10 +-----
 arch/x86/lib/board.c                  |    8 +----
 common/board_f.c                      |    6 ----
 common/spl/spl.c                      |    7 ----
 drivers/mtd/nand/mxc_nand_spl.c       |   10 +-----
 include/configs/mx31pdk.h             |    1 +
 include/configs/tx25.h                |    1 +
 lib/Makefile                          |    1 +
 lib/hang.c                            |   47 ++++++++++++++++++++++++
 23 files changed, 109 insertions(+), 199 deletions(-)
 create mode 100644 lib/hang.c

-- 
1.7.10.4



More information about the U-Boot mailing list