[U-Boot] [PATCH v2 04/12] i2c: add Faraday FTI2C010 I2C controller support

Wolfgang Denk wd at denx.de
Thu Apr 18 12:54:29 CEST 2013


Dear Kuo-Jung Su,

In message <1366277139-29728-5-git-send-email-dantesu at gmail.com> you wrote:
...
> +#define I2C_READ(r)		le32_to_cpu(readl(r))
> +#define I2C_WRITE(v, r)	writel(cpu_to_le32(v), r)

Please drop these macros and use the real functions instead.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Little known fact about Middle Earth:   The Hobbits had a very sophi-
sticated computer network!   It was a Tolkien Ring...


More information about the U-Boot mailing list