[U-Boot] [PATCH v2 10/12] usb: gadget: add Faraday FOTG210 USB gadget support

[Wolfgang Denk]

Dear Kuo-Jung Su,

In message <1366277139-29728-11-git-send-email-dantesu at gmail.com> you wrote:
> From: Kuo-Jung Su <dantesu at faraday-tech.com>
> 
> The Faraday FOTG210 is an OTG chip which could operate
> as either an EHCI Host or a USB Device as a time.
...
> +	uint32_t maxpacket:16;
> +	uint32_t id:4;
> +	uint32_t stopped:1;
> +	uint32_t rsvd:11;

Please do NOT use bit fields.  Fix globally.

> +#define USB_READ(r)			le32_to_cpu(readl(r))
> +#define USB_WRITE(v, r)		writel(cpu_to_le32(v), r)
> +#define USB_SETBITS(m, r)	setbits_le32(r, m)
> +#define USB_CLRBITS(m, r)	clrbits_le32(r, m)

As before...


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
e-credibility: the non-guaranteeable likelihood that  the  electronic
data you're seeing is genuine rather than somebody's made-up crap.
- Karl Lehenbauer