[U-Boot] [PATCH v2 12/12] arm: add Faraday A36x SoC platform support

[Wolfgang Denk]

Dear Kuo-Jung Su,

In message <1366277139-29728-13-git-send-email-dantesu at gmail.com> you wrote:
...
> +#define CONFIG_FTMAC110        1
> +#define CONFIG_ETHADDR         00:84:14:72:61:69 /* used by env_common.c */
> +#define CONFIG_NETMASK         255.255.255.0
> +#define CONFIG_IPADDR          10.0.0.123
> +#define CONFIG_SERVERIP        10.0.0.128

NAK.  We don't allow static global network configurations like that.


> +#define CONFIG_FTGMAC100       1
> +#define CONFIG_PHY_MAX_ADDR    32 /* used by Ratbert's ftgmac100 only */
> +#define CONFIG_FTGMAC100_EGIGA 1  /* used by Ratbert's ftgmac100 only */
> +#define CONFIG_ETHADDR         00:84:14:72:61:69 /* used by env_common.c */
> +#define CONFIG_NETMASK         255.255.255.0
> +#define CONFIG_IPADDR          10.0.0.123
> +#define CONFIG_SERVERIP        10.0.0.128

NAK again.

Hm... this looks like a LOT of repeated code.  Can you please factor
out the common parts into a separate file?


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Vulcans worship peace above all.
	-- McCoy, "Return to Tomorrow", stardate 4768.3