[U-Boot] [PATCH 2/6] nand: Add SPL_NAND support to mxc_nand_spl
Marek Vasut
marex at denx.de
Fri Apr 19 19:11:04 CEST 2013
Dear Philip Paeps,
> On 2013-04-19 06:10:51 (+0200), Marek Vasut <marex at denx.de> wrote:
> > To avoid the old function which are used with the nand_spl/ stuff
> > getting in the way of NAND SPL framework, the macro
> > CONFIG_SPL_NAND_LEGACY was introduced and two remaining legacy
> > boards were adjusted. These board need to be either fixed or
> > removed in the long run, but I don't have either.
>
> It sounds like "fixing" these boards is mainly a matter of confirming
> that a configuration for them based around CONFIG_SPL_FRAMEWORK will fit
> in 2K. If so, I don't think there is any reason to keep legacy support
> around.
These boards are too limited, so we can do nothing about them but to keep this
hack in.
> > +void nand_init(void) {}
> > +void nand_deselect(void) {}
>
> Couldn't you just rename nfc_nand_init() to nand_init()?
What good would that do?
Best regards,
Marek Vasut
More information about the U-Boot
mailing list