[U-Boot] [PATCH 1/2] net: ks8851_mll: add ethernet support

Tom Rini trini at ti.com
Tue Apr 23 17:34:06 CEST 2013


On Tue, Apr 23, 2013 at 06:17:27PM +0800, Bo Shen wrote:

> From: Roberto Cerati <roberto.cerati at bticino.it>
> 
> The device interface is 16 bits wide.
> All the available packets are read from the incoming fifo.
[snip]
> +/* union ks_tx_hdr - tx header data
> + * @txb: The header as bytes

/*
 * union ks_tx_hdr...

Please fix globally.

[snip]
> +#define	RXFSHR_ERR			(RXFSHR_RXCE | RXFSHR_RXRF |\

#define<space> please, thanks.

Looks fine aside from these style problems however, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130423/9179269a/attachment.pgp>


More information about the U-Boot mailing list