[U-Boot] [PATCH v3 6/7] powerpc: Build arch/powerpc/lib/bootm.o depending on CONFIG_CMD_BOOTM

Wolfgang Denk wd at denx.de
Fri Apr 26 09:09:08 CEST 2013


Dear Dirk Eibach,

In message <1366958892-5911-7-git-send-email-dirk.eibach at gdsys.cc> you wrote:
> From: Dirk Eibach <eibach at gdsys.de>
> 
> Signed-off-by: Dirk Eibach <dirk.eibach at gdsys.cc>
> ---
> Changes in v3: None
> Changes in v2: None
> 
>  arch/powerpc/lib/Makefile |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/powerpc/lib/Makefile b/arch/powerpc/lib/Makefile
> index 59c723b..8c4920b 100644
> --- a/arch/powerpc/lib/Makefile
> +++ b/arch/powerpc/lib/Makefile
> @@ -63,7 +63,7 @@ ifndef CONFIG_SYS_GENERIC_BOARD
>  COBJS-y	+= board.o
>  endif
>  endif
> -COBJS-y	+= bootm.o
> +COBJS-$(CONFIG_CMD_BOOTM) += bootm.o

NAK.

The idea makes sense, but please implement it consistently for all
architectures, i. e. fix it in all of:

	arch/arm/lib/Makefile
	arch/avr32/lib/Makefile
	arch/m68k/lib/Makefile
	arch/microblaze/lib/Makefile
	arch/mips/lib/Makefile
	arch/nds32/lib/Makefile
	arch/nios2/lib/Makefile
	arch/openrisc/lib/Makefile
	arch/powerpc/lib/Makefile
	arch/sh/lib/Makefile
	arch/sparc/lib/Makefile
	arch/x86/lib/Makefile


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Motto of the Electrical Engineer: Working computer hardware is a  lot
like an erect penis: it stays up as long as you don't fuck with it.


More information about the U-Boot mailing list