[U-Boot] [PATCH v4 01/10] imx: Homogenize and fix fuse register definitions

[Stefano Babic]

On 26/04/2013 10:03, Benoît Thébaudeau wrote:
> Hi Stefano,
> 

Hi  Benoît,

>> I would like to apply your patches and I see some warning from
>> clearpatch. Some of them are very annoying and I think to ignore them,
>> but before doing that I ask to ML about it. It seems to me that
>> checkpatch make stonger tests as in the past, and I do not know if all
>> of them are meaningful. Or better, I do not think they are.
> 
> Indeed, I have noticed that too since last release. I ignored those on purpose
> because they all seem wrong.

Agree, some of them are non-sense

>> I would say that this enforcement is crap. The code in the patch is easy
>> to read. I want to ignore this warning.
> 
> Yes, and that's usual Linux coding style, which is the official coding style for
> U-Boot as well.

Right.

> 
>> CHECK: Alignment should match open parenthesis
>> #1102: FILE: drivers/misc/fsl_iim.c:118:
>> +	if (bank >= ARRAY_SIZE((*regs)->bank) ||
>> +			word >= ARRAY_SIZE((*regs)->bank[0].word) ||
>>
>> Ditto
>>
>> WARNING: line over 80 characters
>> #1190: FILE: drivers/misc/fsl_iim.c:206:
>> +		puts("fsl_iim fuse_sense(): Explicit sense cycle did not complete\n");
>>
>>
>> Ok, this is the one that must be fixed, even if then we have the warning
>> with "quoted string"
> 
> Initially, this line was less than 80 characters because I had split the string.
> But checkpatch complained about the literal string being split, so I kept it on
> a single line, which makes sense here for grep-ability: It is an error message,
> and all parts of this string are constant (i.e. not printf-ed). And Scott Wood
> had already made me do such changes in the past. What should I do?

Do not change - for me it is ok, and we have explained here why we think
it is right.

> 
> Would it be possible to have an official detailed coding style everybody agrees
> on somewhere? Apparently, the rules are not the same for all custodians.

Really U-Boot follows the same code-styling as Linux, or it should be.
checkpatch should help us to have the same rules, but apparently it does
not (or not always).

> 
>> WARNING: line over 80 characters
>> #2017: FILE: drivers/misc/mxc_ocotp.c:8:
>> + *
>> http://git.freescale.com/git/cgit.cgi/imx/uboot-imx.git/tree/drivers/misc/imx_otp.c?h=imx_v2009.08_1.1.0&id=9aa74e6,
>>
>> Ditto
> 
> I did not know what to do with this one. As it is a URL, I considered it as
> unsplittable. So should the 80-character limit really apply here too?

Yes, sorry, this is a URL - IMHO it is ok.

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================