[U-Boot] [PATCH v3 09/11] usb: gadget: add Faraday FOTG210 USB gadget support

Marek Vasut marex at denx.de
Fri Apr 26 14:21:46 CEST 2013


Dear Kuo-Jung Su,

> From: Kuo-Jung Su <dantesu at faraday-tech.com>
> 
> The Faraday FOTG210 is an OTG chip which could operate
> as either an EHCI Host or a USB Device as a time.
> 
> Signed-off-by: Kuo-Jung Su <dantesu at faraday-tech.com>
> CC: Marek Vasut <marex at denx.de>

Same rambling as for the other patch, bits should have proper names defined in 
the fotg_....h header file. You should avoid calling 
dcache_enable()/dcache_disable() throughout the driver, why do you need to do 
that? Rather implement proper cacheline flushing/invalidation.

Best regards,
Marek Vasut


More information about the U-Boot mailing list