[U-Boot] [PATCH v1] mmc: bfin: Ensure MMR writing is done before next command.
Sonic Zhang
sonic.adi at gmail.com
Sat Apr 27 13:21:47 CEST 2013
Hi Mike
On Sat, Apr 27, 2013 at 7:14 PM, Mike Frysinger <vapier at gentoo.org> wrote:
> On Saturday 27 April 2013 07:04:10 Sonic Zhang wrote:
>> From: Sonic Zhang <sonic.zhang at analog.com>
>>
>> - Ensure MMR writing is done before next command.
>> - Invalidate the buffer before starting to read.
>
> this patch was written by Cliff, not yourself. the description really doesn't
> match reality, and no one has yet to explain what this is doing. i'm fairly
> certain Cliff, when presented with the bug (iirc, it was "mmc doesn't work at
> low SCLK") just threw in a crap ton of SSYNCs to slow the driver down and
> shuffled some code until it worked. no real analysis as to what was actually
> necessary.
>
> hence, i never pushed this upstream. i still don't think this belongs in
> mainline.
Good catch. I can't find the log of this patch in local tree, because
you moved the bfin_sdh.c someday.
Yes, this patch looks like a workaround. So, ignore it.
Regards,
Sonic
More information about the U-Boot
mailing list