[U-Boot] [PATCH 4/5] vybrid: add eSDHC driver support

Wang Huan-B18965 B18965 at freescale.com
Sun Apr 28 13:07:14 CEST 2013


> 
> On 12/04/2013 08:53, Alison Wang wrote:
> > This patch adds eSDHC driver support for vybrid platform.
> >
> > Signed-off-by: TsiChung Liew <tsicliew at gmail.com>
> > Signed-off-by: Jason Jin <Jason.jin at freescale.com>
> > Signed-off-by: Alison Wang <b18965 at freescale.com>
> > ---
> >  drivers/mmc/fsl_esdhc.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/mmc/fsl_esdhc.c b/drivers/mmc/fsl_esdhc.c index
> > 35f879e..f258868 100644
> > --- a/drivers/mmc/fsl_esdhc.c
> > +++ b/drivers/mmc/fsl_esdhc.c
> > @@ -1,5 +1,5 @@
> >  /*
> > - * Copyright 2007, 2010-2011 Freescale Semiconductor, Inc
> > + * Copyright 2007, 2010-2013 Freescale Semiconductor, Inc
> 
> I do not think you can change the Copyright line only for adding a line
> of code.
[Alison Wang] Agree.
> 
> > -#ifndef ARCH_MXC
> > +#if !defined(ARCH_MXC) && !defined(CONFIG_VYBRID)
> >  	/* Enable cache snooping */
> >  	esdhc_write32(&regs->scr, 0x00000040);  #endif
> 
> I am also not sure if we need CONFIG_VYBRID (but then it should be
> ARCH_VYBRID) or we can let flow these processors into the i.MX family.
[Alison Wang] Agree, I will remove this modification and let Vybrid into the i.MX family in the next version patches. Thanks.
> 

Thanks!

Best Regards,
Alison Wang




More information about the U-Boot mailing list