[U-Boot] [PATCH 01/16] i2c, ppc4xx_i2c: switch to new multibus/multiadapter support

Heiko Schocher hs at denx.de
Mon Apr 29 16:14:33 CEST 2013


Hello Dirk,

On 25.04.2013 14:40, Dirk Eibach wrote:
> Signed-off-by: Dirk Eibach <dirk.eibach at gdsys.cc>
> Cc: Heiko Schocher <hs at denx.de>
> Cc: Stefan Roese <sr at denx.de>
> ---
> This patch is based on http://git.denx.de/?p=u-boot/u-boot-i2c.git;a=shortlog;h=refs/heads/20130416_multibus_v2.
> Heiko said:
> "... and if the merge window opens
> I post this patch with the other patches for this new
> i2c framework on the ML."
> So, Heiko, the merge window is wide open, your turn now :)

;-) I try to do this this week ...

Thanks for your work, patch seems good to me, just one nitpicking:


[hs at pollux u-boot]$ ./tools/checkpatch.pl mbox
WARNING: Avoid CamelCase: <get_OPB_freq>
#1264: FILE: drivers/i2c/ppc4xx_i2c.c:128:
+       divisor = (get_OPB_freq() - 1) / 10000000;

total: 0 errors, 1 warnings, 0 checks, 1662 lines checked

NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX MULTISTATEMENT_MACRO_USE_DO_WHILE USLEEP_RANGE

mbox has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
[hs at pollux u-boot]$

This should be fixed too, but this is not only i2c specific ... so I
accept your patch and add it to my multibus branch, make some further
tests, and then post it again in the patchserie, ok?

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany


More information about the U-Boot mailing list