[U-Boot] [PATCH] drivers/block/systemace: fixes read/write words for bus width = 8

Wolfgang Denk wd at denx.de
Thu Jan 3 08:44:02 CET 2013


Dear Michal Simek,

In message <CAHTX3d+shCmUjaXzS0oS5pT8a89cyA9UKemc+oRk5xk6qRNrdQ at mail.gmail.com> you wrote:
> 
> > You say, if one sets width to 8 bits, then the code fails when the bus
> > is actually 16 bits wide?
...
> Here is that function with my comment about missing "else".
> In ace_writew function we shouldn't write 16bit value when width is 8.
> (It probably doesn't break anything but it is not correct - I will
> check it on the HW)

I see.  Well, I think the commit message is not really clear.  I
definitely misunderstood it.  Maybe it can be improved?

Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I have the simplest tastes.  I am always satisfied with the best.
                                                       -- Oscar Wilde


More information about the U-Boot mailing list