[U-Boot] [PATCH] drivers/block/systemace: replaced in16/out16 with more common readw/writew macros

Wolfgang Denk wd at denx.de
Thu Jan 3 13:05:46 CET 2013


Dear Alexey Brodkin,

In message <1357139186-9172-1-git-send-email-alexey.brodkin at gmail.com> you wrote:
> Most architectures don't have symbols "in16"/"out16" defined.
> Only Microblaze/PowerPC/Spark architectures do have them defined.
> 
> At the same time there're much more common macros "readw"/"writew" for
> 16-bit data access defined in most of architectures (in
> linux kernel header "io.h").
> 
> So use of "readw"/"writew" makes it possible to build this driver for
> virtually any architecture.

NAK.  As expected, this breaks big endian systems like PowerPC.

Tested on AMCC "katmai" board (PPC440SPe):

before (current master):

U-Boot 2013.01-rc2-00174-ge56cdd7 (Jan 03 2013 - 12:41:58)
...
=> fatls ace 0 mnt-xsa
            ./
            ../
  1250875   kernel.img 
 19071970   ramdisk.img 

2 file(s), 2 dir(s)


After your patch applied:

U-Boot 2013.01-rc2-00174-ge56cdd7-dirty (Jan 03 2013 - 13:01:27)
...
=> fatls ace 0 mnt-xsa
**** ACE CompactFlash not found.
** Bad device size - ace 0 **


So clear NAK.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Every little picofarad has a nanohenry all its own.      - Don Vonada


More information about the U-Boot mailing list