[U-Boot] [PATCH] drivers/block/systemace: replaced in16/out16 with more common readw/writew macros

Michal Simek monstr at monstr.eu
Thu Jan 3 14:03:34 CET 2013


2013/1/3 Wolfgang Denk <wd at denx.de>:
> Dear Alexey Brodkin,
>
> In message <1357139186-9172-1-git-send-email-alexey.brodkin at gmail.com> you wrote:
>> Most architectures don't have symbols "in16"/"out16" defined.
>> Only Microblaze/PowerPC/Spark architectures do have them defined.
>>
>> At the same time there're much more common macros "readw"/"writew" for
>> 16-bit data access defined in most of architectures (in
>> linux kernel header "io.h").
>>
>> So use of "readw"/"writew" makes it possible to build this driver for
>> virtually any architecture.
>
> NAK.  As expected, this breaks big endian systems like PowerPC.
>
> Tested on AMCC "katmai" board (PPC440SPe):
>
> before (current master):
>
> U-Boot 2013.01-rc2-00174-ge56cdd7 (Jan 03 2013 - 12:41:58)
> ...
> => fatls ace 0 mnt-xsa
>             ./
>             ../
>   1250875   kernel.img
>  19071970   ramdisk.img
>
> 2 file(s), 2 dir(s)
>
>
> After your patch applied:
>
> U-Boot 2013.01-rc2-00174-ge56cdd7-dirty (Jan 03 2013 - 13:01:27)
> ...
> => fatls ace 0 mnt-xsa
> **** ACE CompactFlash not found.
> ** Bad device size - ace 0 **
>

Just a question is this 8bit width or 16bit?
I have checked with our hw guy and we don't have hw board for 8bit width.

Thanks,
Michal

-- 
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian


More information about the U-Boot mailing list