[U-Boot] [PATCH 1/1] console: Improve TFTP booting performance

[Wolfgang Denk]

Dear Jim Lin,

In message <1359097425-20517-1-git-send-email-jilin at nvidia.com> you wrote:
> TFTP booting is observed a little bit slow, especially when a USB
> keyboard is installed.
> The fix is to check whether Ctrl-C key is pressed every
> CONFIG_CTRLC_POLL_MS ms.
> If CONFIG_CTRLC_POLL_MS is not defined in configuration file, we
> define it as 1000.

...also:

> +#ifndef CONFIG_CTRLC_POLL_MS
> +/*
> + * Process Ctrl-C every 1000 ms by default to improve performance
> + * (like TFTP boot) when interlaced with other tasks.
> + */
> +#define CONFIG_CTRLC_POLL_MS 1000
> +#endif
> +static unsigned long ctrlc_ts = CONFIG_CTRLC_POLL_MS;

Don't set such a default.  If this is good for you, OK.  But for all
others, the behaviour should not change at all.


Also, are you positively sure that your callto get_timer() does not
mess up with other timers in the network subsystem?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
You're too beautiful to ignore.  Too much woman.
	-- Kirk to Yeoman Rand, "The Enemy Within", stardate unknown