[U-Boot] [PATCH 1/1] console: Improve TFTP booting performance

Jim Lin jilin at nvidia.com
Tue Jan 29 07:35:34 CET 2013


On Fri, 2013-01-25 at 17:20 +0800, Wolfgang Denk wrote:
> Dear Jim Lin,
> 
> In message <1359097425-20517-1-git-send-email-jilin at nvidia.com> you wrote:
> > TFTP booting is observed a little bit slow, especially when a USB
> > keyboard is installed.
> > The fix is to check whether Ctrl-C key is pressed every
> > CONFIG_CTRLC_POLL_MS ms.
> > If CONFIG_CTRLC_POLL_MS is not defined in configuration file, we
> > define it as 1000.
> 
> ...also:
> 
> > +#ifndef CONFIG_CTRLC_POLL_MS
> > +/*
> > + * Process Ctrl-C every 1000 ms by default to improve performance
> > + * (like TFTP boot) when interlaced with other tasks.
> > + */
> > +#define CONFIG_CTRLC_POLL_MS 1000
> > +#endif
> > +static unsigned long ctrlc_ts = CONFIG_CTRLC_POLL_MS;
> 
> Don't set such a default.  If this is good for you, OK.  But for all
> others, the behaviour should not change at all.
> 
> 
> Also, are you positively sure that your callto get_timer() does not
> mess up with other timers in the network subsystem?
> 
OK. I will rewrite and check again.
Thanks.

--nvpublic




More information about the U-Boot mailing list