[U-Boot] [PATCH v4 2/3] ARM: Tegra: USB: EHCI: Add support for Tegra30/Tegra114

[Stephen Warren]

On 06/20/2013 02:13 AM, Jim Lin wrote:
> Tegra30 and Tegra114 are compatible except PLL parameters.
> 
> Tested on Tegra30 Cardhu, and Tegra114 Dalmore
> platforms. All works well.

> Changes in v4:

>  - In pinmux-config-cardhu.h, chnage GMI_AD13 pinmux state to be OUTPUT
>    in order to be driven HIGH for Beaver board.

That should be reverted. As I mentioned in my previous response,
GMI_AD13 is the wrong pin.

> diff --git a/board/nvidia/cardhu/pinmux-config-cardhu.h b/board/nvidia/cardhu/pinmux-config-cardhu.h

> @@ -332,7 +332,9 @@ static struct pingroup_config unused_pins_lowpower[] = {
>  	DEFAULT_PINMUX(GMI_AD7, NAND, NORMAL, TRISTATE, OUTPUT),
>  	DEFAULT_PINMUX(GMI_AD9, PWM1, NORMAL, NORMAL, OUTPUT),
>  	DEFAULT_PINMUX(GMI_AD11, NAND, NORMAL, NORMAL, OUTPUT),
> -	DEFAULT_PINMUX(GMI_AD13, NAND, UP, NORMAL, INPUT),
> +
> +	/* Beaver, USB13_VBUS_PULLUP GPIO */
> +	DEFAULT_PINMUX(GMI_AD13, NAND, NORMAL, NORMAL, OUTPUT),

I assume this table is shared between Cardhu and Beaver. You can't make
Beaver-specific changes to it. If you need to make Beaver-specific
changes, then you need to create a separate pinmux-config-beaver.h, or
use #ifdefs based on the board you're compiling for.

Luckily in this case, GMI_AD13 is not connected on Cardhu, so you
haven't damaged any HW by testing this change on Cardhu.

> diff --git a/drivers/usb/host/ehci-tegra.c b/drivers/usb/host/ehci-tegra.c

> +struct fdt_usb_controller {
> +	int compat;
> +	/* flag to determine whether controller supports hostpc register */
> +	u8 has_hostpc:1;

I'd suggest "bool" here, or at least "u32 has_hostpc:1"; alignment
concerns will pad the storage out to 32-bit anyway, so you may as well
use a 32-bit variable as is normal for bit-fields.