[U-Boot] [PATCH v2 4/7] cmd: fpga: Move fpga_loadbitstream to fpga.c

[Michal Simek]

On 05/01/2013 05:03 PM, Tom Rini wrote:
> On Wed, May 01, 2013 at 10:59:20AM +0200, Michal Simek wrote:
> 
>> In bitstream decoding you can directly check device
>> which you want to load and in fpga.c are fpga_validate
>> and fpga_dev_info functions which should be used for it.
>>
>> Signed-off-by: Michal Simek <michal.simek at xilinx.com>
> [snip]
>> +++ b/drivers/fpga/fpga.c
> [snip]
>> +#else
>> +	printf("Bitstream support only for Xilinx devices\n");
>> +	return FPGA_FAIL;
>> +#endif
> 
> How about we re-work this as a __weak fpga_loadbitstream in
> drivers/fpga/fpga.c that just says "Bitstream support not implemented
> for this FPGA device", return FPGA_FAIL, and move the xilinx one into
> drivers/fpga/xilinx.c ?

yep. Make sense to do it because at least from this code altera or lattice
don't support bitstream loading.
It will be more problematic if there is a board on the market
with different fpgas.

I even not sure if other fpga vendors have bitstream with any header
which should be used by this command.

Thanks,
Michal

-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 263 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130501/152b5e04/attachment.pgp>