[U-Boot] [PATCH 1/9] mxs: Make the names of the elements of mxs_pinctrl_regs shorter

Marek Vasut marex at denx.de
Thu May 2 02:12:27 CEST 2013


Dear Fabio Estevam,

> On Wed, May 1, 2013 at 8:26 PM, Marek Vasut <marex at denx.de> wrote:
> > Dear Fabio Estevam,
> > 
> >> From: Fabio Estevam <fabio.estevam at freescale.com>
> >> 
> >> Currently when accessing an element of mxs_pinctrl_regs structure we do:
> >> 
> >> &pinctrl_regs->hw_pinctrl_emi_ds_ctrl_set
> >> 
> >> The 'hw_pinctrl' prefix is a redundant information as we already know
> >> that we are accessing a pinctrl register.
> >> 
> >> Signed-off-by: Fabio Estevam <fabio.estevam at freescale.com>
> > 
> > Now this single file is inconsistent with the rest of the register header
> > files.
> 
> I can change the other header files as well.

Yes, but a separate patchset can do that. Let's keep it consistent please.

Best regards,
Marek Vasut


More information about the U-Boot mailing list