[U-Boot] [PATCH v2 2/8] mxs: Fix PULLUP/NOPULL definitions

Fabio Estevam fabio.estevam at freescale.com
Thu May 2 16:04:16 CEST 2013


On mx23 and mx28 the pullup bits are defined as:

- 0: Enable the internal pad keeper 
- 1: Disable the internal pad keeper

Fix the definitions as they are currently the opposite.

Cc: Lauri Hintsala <lauri.hintsala at bluegiga.com>
Signed-off-by: Fabio Estevam <fabio.estevam at freescale.com>
---
This affects mx28 as well, so also adding Lauri.

I also tested on mx28evk and behavior is fine after this change.

Changes since v1:
- Newly introduced

 arch/arm/include/asm/arch-mxs/iomux.h |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/include/asm/arch-mxs/iomux.h b/arch/arm/include/asm/arch-mxs/iomux.h
index 66dcd36..70300d5 100644
--- a/arch/arm/include/asm/arch-mxs/iomux.h
+++ b/arch/arm/include/asm/arch-mxs/iomux.h
@@ -78,8 +78,8 @@ typedef u32 iomux_cfg_t;
 #define PAD_3V3			0
 #endif
 
-#define PAD_NOPULL		0
-#define PAD_PULLUP		1
+#define PAD_PULLUP		0
+#define PAD_NOPULL		1
 
 #define MXS_PAD_4MA	((PAD_4MA << MXS_PAD_MA_SHIFT) | \
 					MXS_PAD_MA_VALID_MASK)
-- 
1.7.9.5




More information about the U-Boot mailing list