[U-Boot] [PATCH v3 1/7] mx23: Fix pad voltage selection bit

[Otavio Salvador]

On Thu, May 2, 2013 at 11:24 PM, Marek Vasut <marex at denx.de> wrote:
> Dear Fabio Estevam,
>
>> From: Fabio Estevam <fabio.estevam at freescale.com>
>>
>> On mx23 the pad voltage selection bit needs to be always '0', since '1' is
>> a reserved value.
>>
>> For example:
>>
>> Pin 108, EMI_A06 pin voltage selection:
>> 0= 1.8V (mDDR) or 2.5V (DDR1);
>> 1= reserved.
>>
>> Fix the pad voltage definitions for the mx23 case.
>>
>> Signed-off-by: Fabio Estevam <fabio.estevam at freescale.com>
>
> Acked-by: Marek Vasut <marex at denx.de>
>
> but then, should we not just undefine this PAD_3V3 for MX23 altogether so noone
> is tempted to use it?

I think for code readability it'd be good to have it in place. It
makes it more obvious for people looking at code.

--
Otavio Salvador                             O.S. Systems
E-mail: otavio at ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br