[U-Boot] [PATCH] tools: default image: use ih_size for checking data size

[Wolfgang Denk]

Dear Jonas Gorski,

In message <1367581025-26740-1-git-send-email-jogo at openwrt.org> you wrote:
> Common image usage is uImage + appended rootfs, so the the uImage data

No, this is not at all "common usage".  Actually this something you
should never do.

> is only part of the total image. So read out and use the header's
> ih_size field instead of the total file size.
> 
> To prevent reading over the end of the buffer, check that the image file
> is big enough to contain the data before calculating its checksum.
> 
> Before:
> ~# mkimage -l dir665_fw_100NA.bin
> mkimage: ERROR: "dir665_fw_100NA/dir665_fw_100NA.bin" has corrupted data!

Sorry, I don't know how you create your image files, but you must be
doing something fundamentally wrong.  If mkimage reports a bug here,
it is probably right.  If the actual payload size is different from
the content of the  ih_size  field, then your image _is_ broken.

NAK.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The aim of science is not to open the door to everlasting wisdom  but
to set a limit on everlasting error.                 - Bertolt Brecht