[U-Boot] [PATCH 12/12] imx: mx5: Remove legacy iomux support

Stefano Babic sbabic at denx.de
Sun May 5 16:58:40 CEST 2013


On 03/05/2013 15:18, Marek Vasut wrote:
> Dear Benoît Thébaudeau,
> 
>> Dear Marek Vasut,
>>
>> On Friday, May 3, 2013 2:42:04 PM, Marek Vasut wrote:
>>> Dear Benoît Thébaudeau,
>>>
>>>> Dear Marek Vasut,
>>>>
>>>> On Friday, May 3, 2013 4:38:43 AM, Marek Vasut wrote:
>>>>> Dear Benoît Thébaudeau,
>>>>>
>>>>>> Legacy iomux support is no longer needed now that all boards have
>>>>>> been converted to iomux-v3.
>>>>>>
>>>>>> Signed-off-by: Benoît Thébaudeau <benoit.thebaudeau at advansee.com>
>>>>>
>>>>> Yes, good move
>>>>>
>>>>> Reviewed-by: Marek Vasut <marex at denx.de>
>>>>
>>>> How do you plan to handle the conversion to iomux-v3 of the
>>>> not-yet-applied
>>>>
>>>> m53evk:
>>>>  - You rebase your series on mine?
>>>>  - I rebase my series on yours?
>>>
>>> Did you not send this stuff after m53evk?
>>
>> Correct.
>>
>>> So let's let Stefano merge it all
>>> in
>>> sequence
>>
>> We can do that, but this will add another conversion patch that would not
>> be needed the other way around, for something not yet applied.
>>
>>> (poor Stefano though, patches seem to be piling up).
>>
>> True.
>>
>>>>  - I convert m53evk, then I send you the file so that you can refactor
>>>>  your
>>>>  
>>>>    series and trivially rebase it on mine?
>>>
>>> I can convert it, but being lazy as hell, of course the idea of you doing
>>> all the work seems very tempting ;-)
>>
>> After having done all other boards, one more should be quick. ;)
>>
>> So I will:
>>  - Extract m53evk.c from your series.
>>  - Convert it to iomux-v3.
>>  - Send it to you.
>>
>> Then you will:
>>  - Update and resend your series with this file.
>>
>> Then Stefano will:
>>  - Apply my mx25/35/5x series.
>>  - Apply your converted m53evk series.
> 
> Hm, I will still argument with the fact that yours was sent later and for me, 
> this will mean another round of testing. If we swap them, I will have a good 
> bisect point right before your series too.

Marek, apart who send patches earlier, I stick with Benoit's approach.
The reason: first patches that provide a general framework (in this
case, the iomux) for the SOC, and then board support already using the
right approach.

Best regards,
Stefano


-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================


More information about the U-Boot mailing list