[U-Boot] [PATCH v2 04/10] powerpc/ppc4xx: Use generic FPGA accessors in gdsys common code

Wolfgang Denk wd at denx.de
Mon May 6 16:07:15 CEST 2013


Dear dirk.eibach at gdsys.cc,

In message <1367847325-21463-5-git-send-email-dirk.eibach at gdsys.cc> you wrote:
>
...
> +			fpga_set_reg(k, REG(reflection_low),
> +				     REFLECTION_TESTPATTERN);

This breaks bisecting.  You reference functions which you only add in
a later patch.

Please fix this.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
My play was a complete success.  The audience was a failure.


More information about the U-Boot mailing list