[U-Boot] [PATCH v2 04/10] powerpc/ppc4xx: Use generic FPGA accessors in gdsys common code

Dirk Eibach dirk.eibach at gdsys.cc
Mon May 6 17:02:12 CEST 2013


Hi Tom,

> On Mon, May 06, 2013 at 04:07:15PM +0200, Wolfgang Denk wrote:
>> Dear dirk.eibach at gdsys.cc,
>> 
>> In message <1367847325-21463-5-git-send-email-dirk.eibach at gdsys.cc> 
>> you wrote:
>>> 
>> ...
>>> +			fpga_set_reg(k, REG(reflection_low),
>>> +				     REFLECTION_TESTPATTERN);
>> 
>> This breaks bisecting.  You reference functions which you only add in
>> a later patch.
> 
> Note that 'git rebase -i' and the exec keyword can help you test
> bisectability.

I know 'git rebase -i', but what is the exec keyword? It seems there is 
some room for improvement on patman :)

Cheers
Dirk


More information about the U-Boot mailing list