[U-Boot] [PATCH] Powerpc/esdhc: Correct judgement for DATA PIO mode

[Zhang Haijun-B42677]

Oh, sorry

I mistaken to git am the patch used internally.
Actually there are changes.
I'll send patch v2.

Regards
Haijun.

From: Andy Fleming [mailto:afleming at gmail.com]
Sent: Monday, May 06, 2013 11:46 PM
To: Zhang Haijun-B42677
Cc: U-Boot list; Fleming Andy-AFLEMING; sun york-R58495
Subject: Re: [U-Boot] [PATCH] Powerpc/esdhc: Correct judgement for DATA PIO mode

I'm confused. The patch you submitted internally was totally different.

On Mon, May 6, 2013 at 1:23 AM, Haijun.Zhang <Haijun.Zhang at freescale.com<mailto:Haijun.Zhang at freescale.com>> wrote:
From: "Haijun.Zhang" <Haijun.Zhang at freescale.com<mailto:Haijun.Zhang at freescale.com>>

The logic for the whether to configure for polling or DMA
was mistakenly reversed in this patch:

Commit 7b43db92110ec2f15c5f7187a165f2928464966b
drivers/mmc/fsl_esdhc.c: fix compiler warnings


diff --git a/drivers/mmc/fsl_esdhc.c b/drivers/mmc/fsl_esdhc.c
index e93e38a..8feb3d3 100644
--- a/drivers/mmc/fsl_esdhc.c
+++ b/drivers/mmc/fsl_esdhc.c
@@ -74,7 +74,7 @@ static uint esdhc_xfertyp(struct mmc_cmd *cmd, struct mmc_data *data)

        if (data) {
                xfertyp |= XFERTYP_DPSEL;
-#ifndef CONFIG_SYS_FSL_ESDHC_USE_PIO
+#ifdef CONFIG_SYS_FSL_ESDHC_USE_PIO
                xfertyp |= XFERTYP_DMAEN;
 #endif


This logic is correct, as it is. PIO means NOT DMA. The original patch you sent corrected this part:

#ifndef CONFIG_SYS_FSL_ESDHC_USE_PIO

in esdhc_setup_data. This patch seems to just break things further?

Andy