[U-Boot] [PATCH 1/1] OMAP4/5: I2C: New read/write/probe functions

[Tom Rini]

On Thu, Apr 04, 2013 at 04:40:16PM +0300, Lubomir Popov wrote:

> These new functions are built for OMAP4 and OMAP5 only. The major
> improvement is that the new i2c_read fixes the inability to read
> correctly from certain types of I2C chips.
> 
> - Rewritten i2c_read to operate correctly with all types of chips.
> - Optimized i2c_write. Both read/write functions try to identify
>   unconfigured bus.
> - New i2c_probe performs write access vs read. Optionally selectable
>   via CONFIG_I2C_PROBE_WRITE.
> - Driver supports up to I2C5 (OMAP5; I2C_BASE5 must be defined).
> 
> Signed-off-by: Lubomir Popov <lpopov at mm-sol.com>

So, I've tested the i2c_probe on the was failing last time we tried a
write-style probe and it's OK.  But I'm not sure that we're obeying the
comments I spell out in 168a5acb81a8d92a7effcb2727aaa89367b97e05 about
why we can't do a write-style probe all the same.  Can you be sure we're
following the constraints there?  Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130509/2677b0b6/attachment.pgp>