[U-Boot] [PATCH 3/3] usb: Correct CLEAR_FEATURE code in ehci-hcd

Marek Vasut marex at denx.de
Sat May 11 19:59:37 CEST 2013


Dear Simon Glass,

> On Sat, May 11, 2013 at 10:39 AM, Marek Vasut <marex at denx.de> wrote:
> > Dear Simon Glass,
> > 
> >> This commit broke USB2 on link (Chromebook Pixel):
> >>   020bbcb usb: hub: Power-cycle on root-hub ports
> >> 
> >> However the root cause seems to be a missing mask and missing 'break'
> >> in ehci-hcd.c. This patch fixes both.
> >> 
> >> On link, 'usb start' with a USB keyboard and memory stick inserted now
> >> finds both. The keyboard works as expected. Also ext2ls shows a
> >> directory listing from the memory stick.
> >> 
> >> Signed-off-by: Simon Glass <sjg at chromium.org>
> > 
> > Picking up all three, thanks!
> 
> Thanks, also Julius may have some comments on Monday. Two of the
> patches were reviewed by him, but not the last one, although he
> suggested it.

I just build-tested them, seem OK.

btw. I might be less available this month, sorry about that.

Best regards,
Marek Vasut


More information about the U-Boot mailing list