[U-Boot] Exynos5: cpufreq: Implement frequency scaling for exynos5

Simon Glass sjg at chromium.org
Mon May 13 06:56:07 CEST 2013


Hi Akshay,

On Sun, May 12, 2013 at 11:15 PM, Akshay Saraswat <akshay.s at samsung.com> wrote:
> Hi Simon,
>
>>Hi Akshay,
>>
>>On Wed, Apr 3, 2013 at 12:27 AM, Akshay Saraswat <akshay.s at samsung.com> wrote:
>>> Exynos5 currently runs at full speed i.e. 1.7 GHz everytime.
>>> Scaling down the clock speed in certain situations, may help in
>>> reducing the ARM temperature and power consumption.
>>>
>>> Signed-off-by: Akshay Saraswat <akshay.s at samsung.com>
>>> ---
>>>  arch/arm/include/asm/arch-exynos/cpufreq.h |  54 ++++++
>>>  drivers/power/Makefile                     |   1 +
>>>  drivers/power/exynos-cpufreq.c             | 282 +++++++++++++++++++++++++++++
>>>  3 files changed, 337 insertions(+)
>>>  create mode 100644 arch/arm/include/asm/arch-exynos/cpufreq.h
>>>  create mode 100644 drivers/power/exynos-cpufreq.c
>>
>>There may be a couple of style nits here I think (do you use patman or
>>checkpatch?) but otherwise:
>>
>>Acked-by: Simon Glass <sjg at chromium.org>
>>
>
> Yes, I did use tools/checkpach from u-boot-samsung to verify style errors
> in these patches, I didn't get any. It shows 0 errors and 0 warnings for
> all 4 patches. No wonder, there could be few things which checkpatch might
> not have caught. Please let me know the errors, I'll rectify them.

Sorry I can't see what I noticed last time, it looks good!

> And also, I am pushing one more revision for PMIC set-voltage patch
> with function comment. Please review it.

OK, will do.

I am hoping to collect up all the outstanding patches and put them
somewhere for testing.

Regards,
Simon


More information about the U-Boot mailing list