[U-Boot] [PATCH 1/2] EXYNOS: Export timer_get_us() to get microsecond timer

Rajeshwari Birje rajeshwari.birje at gmail.com
Mon May 13 07:13:44 CEST 2013


Hi Simon,

Thank you for review comments,

On Sat, May 11, 2013 at 8:38 PM, Simon Glass <sjg at chromium.org> wrote:
> On Fri, Mar 22, 2013 at 6:45 PM, Simon Glass <sjg at chromium.org> wrote:
>> Hi Rajeshwari,
>>
>> On Fri, Mar 22, 2013 at 5:28 AM, Rajeshwari Shinde
>> <rajeshwari.s at samsung.com> wrote:
>>> This function, if implemented by the board, provides a microsecond
>>> timer. The granularity may be larger than 1us if hardware does not
>>> support this.
>>>
>>> Signed-off-by: Simon Glass <sjg at chromium.org>
>>> Signed-off-by: Rajeshwari Shinde <rajeshwari.s at samsung.com>
>>> ---
>>>  include/common.h |    8 ++++++++
>>>  1 files changed, 8 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/include/common.h b/include/common.h
>>> index 4ad17ea..0c21edc 100644
>>> --- a/include/common.h
>>> +++ b/include/common.h
>>> @@ -558,6 +558,14 @@ void ddr_enable_ecc(unsigned int dram_size);
>>>  #endif
>>>  #endif
>>>
>>> +#if defined CONFIG_EXYNOS5
>>
>> I don't think we need the #ifdef. If some boards don't have then that is OK.
>
> Further to this, I suppose we can always remove the #ifdef when other
> boards define the function. So:
Will remove the #ifdef and resend the patch soon.
>
> Acked-by: Simon Glass <sjg at chromium.org>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot

-- 
Regards,
Rajeshwari Shinde


More information about the U-Boot mailing list