[U-Boot] [PATCH] common/Makefile: Add new symbol CONFIG_SPL_ENV_SUPPORT to replace CONFIG_SPL_NET_SUPPORT

Tom Rini trini at ti.com
Mon May 13 21:07:14 CEST 2013


On Fri, May 10, 2013 at 07:28:46PM -0500, Scott Wood wrote:
> On 05/10/2013 07:03:07 PM, Wolfgang Denk wrote:
> >Dear ying.zhang at freescale.com,
> >
> >In message
> ><1368182421-859-1-git-send-email-ying.zhang at freescale.com> you
> >wrote:
> >> From: Ying Zhang <b40530 at freescale.com>
> >>
> >> Add a new symbol CONFIG_SPL_ENV_SUPPORT to replace
> >CONFIG_SPL_NET_SUPPORT.
> >
> >Any CONFIG_* stuff must be documented in the README.  Please add this
> >documentation.
> >
> >> In common/Makefile, the environment-related files in SPL is
> >difined by
> >> CONFIG_SPL_NET_SUPPORT, it is wrong.
> >
> >s/difined/defined/
> >
> >Could you please also explain, what exactly is wrong, and how your new
> >code fixes this?
> 
> We will need the environment in SPL for reasons other than network
> support (in particular, hwconfig contains info for how to set up
> DDR).  Yes, this information should go in the changelog.

Note that a3m071 already does SPL + Environment and should be updated,
CONFIG-symbol wise here.  It currently gets away with
env_common/cmd_nvedit being pulled in always on LIBCOMMON and then
discarded when not needed.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130513/751d90c3/attachment.pgp>


More information about the U-Boot mailing list