[U-Boot] [PATCH] usb: asix: Move software resets to basic_init

Marek Vasut marex at denx.de
Tue May 14 00:10:31 CEST 2013


Dear Joe Hershberger,

> On Mon, May 13, 2013 at 10:14 AM, Marek Vasut <marex at denx.de> wrote:
> > Dear Simon Glass,
> > 
> >> From: Julius Werner <jwerner at chromium.org>
> >> 
> >> The ASIX driver calls a basic_init() function during get_info(), so that
> >> not all initialization tasks need to be redone on every init().
> >> Unfortunately, the most important one is still triggered too often: the
> >> driver does a full port and MII reset on every asix_init(), requiring up
> >> to several seconds to reestablish the link.
> >> 
> >> This patch confines that software reset into the asix_basic_init()
> >> function so that it will only be executed once. This saves about a
> >> second of boot time on systems using BOOTP.
> >> 
> >> Note: this patch was previously submitted many moons ago as:
> >>    usb: usbeth: asix: Do a fast init if link already established
> >> 
> >> That patch seens to have been lost or forgotten, so this is a rebased
> >> version. It is tested on snow with a Asix USB dongle (Cisco).
> >> 
> >> Signed-off-by: Julius Werner <jwerner at chromium.org>
> >> Signed-off-by: Simon Glass <sjg at chromium.org>
> >> Reviewed-by: Simon Glass <sjg at chromium.org>
> >> Reviewed-by: Vadim Bendebury <vbendeb at chromium.org>
> > 
> > I'll pick it, but I wonder why Joe didn't ...
> 
> Sorry... just swamped for the moment.

Same here :-/

Best regards,
Marek Vasut


More information about the U-Boot mailing list